| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
| Cc: | Ivan Panchenko <wao(at)mail(dot)ru>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, vignesh C <vignesh21(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: On login trigger: take three |
| Date: | 2021-11-11 09:56:55 |
| Message-ID: | 8F2FC11D-F0B4-41F2-BA7F-BA7F84DBF493@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 11 Nov 2021, at 07:37, Greg Nancarrow <gregn4422(at)gmail(dot)com> wrote:
> I've attached an updated patch, that essentially reinstates the v19
> patch
Thanks! I've only skimmed it so far but it looks good, will do a more thorough
review soon.
+ This flag is used to avoid extra lookups on the pg_event_trigger table during each backend startup.
This should be <structname>pg_event_trigger</structname>. Sorry, missed that
one at that last read-through.
> - dathaslogintriggers -> dathasloginevttriggers flag rename (too
> long?)
I'm not crazy about this name, "evt" is commonly the abbreviation of "event
trigger" (used in evtcache.c etc) so "dathasloginevt" would IMO be better.
That being said, that's still not a very readable name, maybe someone else has
an even better suggestion?
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-11-11 10:34:10 | Re: [PATCH] Partial foreign key updates in referential integrity triggers |
| Previous Message | Amit Kapila | 2021-11-11 09:38:15 | Re: parallel vacuum comments |