| From: | Greg Nancarrow <gregn4422(at)gmail(dot)com> |
|---|---|
| To: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Rahila Syed <rahilasyed90(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Önder Kalacı <onderkalaci(at)gmail(dot)com>, japin <japinli(at)hotmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Steele <david(at)pgmasters(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: row filtering for logical replication |
| Date: | 2022-01-26 22:40:24 |
| Message-ID: | CAJcOf-c7XrtsWSGppb96-eQxPbtg+AfssAtTXNYbT8QuhdyOYA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 26, 2022 at 2:08 PM houzj(dot)fnst(at)fujitsu(dot)com
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> There was a miss in the posted patch which didn't initialize the parameter in
> RelationBuildPublicationDesc, sorry for that. Attach the correct patch this time.
>
A few comments for the v71-0001 patch:
doc/src/sgml/catalogs.sgml
(1)
+
+ <row>
+ <entry role="catalog_table_entry"><para role="column_definition">
+ <structfield>prqual</structfield> <type>pg_node_tree</type>
+ </para>
+ <para>Expression tree (in <function>nodeToString()</function>
+ representation) for the relation's qualifying condition. Null if
+ there is no qualifying condition.</para></entry>
+ </row>
"qualifying condition" sounds a bit vague here.
Wouldn't it be better to say "publication qualifying condition"?
src/backend/commands/publicationcmds.c
(2) check_simple_rowfilter_expr_walker
In the function header:
(i) "etc" should be "etc."
(ii)
Is
+ * - (Var Op Const) Bool (Var Op Const)
meant to be:
+ * - (Var Op Const) Logical-Op (Var Op Const)
?
It's not clear what "Bool" means here.
(3) check_simple_rowfilter_expr_walker
We should say "Built-in functions" instead of "System-functions":
+ * User-defined functions are not allowed. System-functions that are
Regards,
Greg Nancarrow
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-01-26 22:54:21 | Re: Bug in ProcArrayApplyRecoveryInfo for snapshots crossing 4B, breaking replicas |
| Previous Message | Peter Smith | 2022-01-26 22:25:13 | Re: row filtering for logical replication |