Re: [PATCH] Release replication slot on error in SQL-callable slot functions

Hi Bharath,

Two minor naming suggestions: (please take the suggestions if you
think the points are valid)
1. Could MyReplicationSlotSubId be renamed to
MyReplicationSlotSubXactId (or MyReplicationSlotSubTransactionId)

SubId may be read as a subscription ID, whereas this variable stores
the SubTransactionId of the subtransaction that acquired
MyReplicationSlot. The more explicit name would make its purpose
clearer and avoid confusion with logical replication subscriptions.

2., could the comment above AtEOSubXact_ReplicationSlot() be revised from:
/*
* At subxact end, release the replication slot if the subtransaction
* where the slot was acquired is aborted.
*/
to:
/*
* At subxact end, release the replication slot if the subtransaction
* in which the slot was acquired is aborted.
*/
“In which” is more precise here because the slot is acquired during
that subtransaction.

--
Thanks & Regards,
Kedar

On Fri, Sep 18, 2026 at 1:43 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> Hi,
>
> On Wed, Sep 16, 2026 at 6:37 PM Bharath Rupireddy
> <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> >
> > Please find the attached patch for HEAD. I dropped the two unnecessary
> > header file inclusions added in the diff but otherwise took it as-is.
> > If it looks good, I can prepare the patches for all supported
> > branches.
>
> Please find the attached patches for HEAD and all supported branches.
> Thanks to all for reviewing and sharing thoughts.
>
> --
> Bharath Rupireddy
> Amazon Web Services: https://aws.amazon.com