Re: WIP: a way forward on bootstrap data

From: John Naylor <jcnaylor(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: a way forward on bootstrap data
Date: 2018-03-22 15:02:56
Message-ID: CAJVSVGXM2hGeZsz196Mod8JV+KReRzZcewA+PW3Ab4J-THt8wg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/22/18, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> how about letting the line go long, with the comment at the right of
> each definition, with one blank line between struct members, as in the
> sample below? You normally don't care that these lines are too long
> since you seldom edit them -- one mostly adds or remove entire lines
> instead, so there's not as much need for side-by-side diffs as with
> regular code. (One issue with this proposal is how to convince pgindent
> to leave the long lines alone.)

Yeah, it seems when perltidy or pgindent mangle things badly, it's to
try and shoehorn a long line into a smaller number of characters. If
memory serves, I've come across things like this:

pg_node_tree proargdefaults BKI_DEFAULT(_null_); /* list of expression

trees for argument

defaults (NULL if none) */

And thought "only a machine could be so precisely awkward"

-John Naylor

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-03-22 15:07:48 Re: faster testing with symlink installs
Previous Message Tom Lane 2018-03-22 14:57:03 Re: WIP: a way forward on bootstrap data