From: | John Naylor <jcnaylor(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Documentation for bootstrap data conversion |
Date: | 2018-04-09 17:41:06 |
Message-ID: | CAJVSVGXDbaTDuR6H6UscNVy90Jqn0uhENtDYpyAwU1P8BcM4+A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 4/9/18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> As it is now, it will actually collapse consecutive blank lines into
>> one. I maintain that was necessary during conversion to get some
>> semblance of consistency, but now it may not be a good idea to tie
>> developers' hands in surprising ways if they want double blank lines
>> in some places. It would be pretty easy to remove this behavior.
>> Apologies if it was not documented well enough.
>
> I did note that in some internal comments, but forgot it when writing
> this. I agree that now that the conversion is done, it'd be better
> to remove that special case. Would you send a patch for that?
Sure, attached.
-John Naylor
Attachment | Content-Type | Size |
---|---|---|
preserve-all-blank-lines-in-data-files.patch | text/x-patch | 1.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Gasper Zejn | 2018-04-09 18:02:21 | Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS |
Previous Message | Magnus Hagander | 2018-04-09 17:26:40 | Re: pgsql: Revert "Allow on-line enabling and disabling of data checksums" |