Re: unused_oids script is broken with bsd sed

From: John Naylor <jcnaylor(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru>, Andreas Karlsson <andreas(at)proxel(dot)se>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, David Fetter <david(at)fetter(dot)org>
Subject: Re: unused_oids script is broken with bsd sed
Date: 2018-05-04 11:42:36
Message-ID: CAJVSVGUToOYNnmbpE_6TMM8P9G9ZQ8RQNr2zF7HZzA-HbtBckA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/4/18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Well, the work's already done, and personally I think the code is
> cleaner after 9bf28f96c and bad51a49a regardless of whether there's any
> performance benefit. You could call 1f1cd9b5d a wart if you wanted.
> But we've done largely the same thing to pgindent, for one, in the past
> year or so, and I find that to be a usability improvement, independently
> of whether there's any build performance win. My editor gets cranky
> when files change under it for no reason.

Thanks for looking into that. I meant to do so, but it got stuck on
the back burner. I'm happy to report that, running non-parallel make
on my old laptop goes from over 5 minutes to about 5 seconds, when
touching a catalog file.

-John Naylor

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-05-04 11:58:53 Re: make installcheck-world in a clean environment
Previous Message Vladimir Sitnikov 2018-05-04 11:23:08 Re: [HACKERS] Clock with Adaptive Replacement