Re: wrapping in extended mode doesn't work well with default pager

From: Sergey Muraviov <sergey(dot)k(dot)muraviov(at)gmail(dot)com>
To: Greg Stark <stark(at)mit(dot)edu>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Emre Hasegeli <emre(at)hasegeli(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: wrapping in extended mode doesn't work well with default pager
Date: 2014-05-18 17:46:26
Message-ID: CAJTaR3378oBouExfpgZaMuNhzPThZYjWrU7xF-tDKPPYmNNEUA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I found some new bugs and fix them.
And I had to make many changes.

2014-05-17 21:31 GMT+04:00 Greg Stark <stark(at)mit(dot)edu>:

> Sorry, a couple things still look to not be quite right.
>
> 1) The width of the table when linestyle=old-ascii and border=0 or
> border=1 (and expanded=on and format=wrapped) seems to off by one.
>
> 2) The hyphens following the RECORD NN are short by one
>
> I'm surprised the last patch was so big since it sounded like a simple
> off-by-one bug. It looks like you've removed the leading space on the
> border=0 expanded case. I guess that makes sense but we should
> probably stop making significant changes now and just focus on fixing
> the off by one bugs.
>

--
Best regards,
Sergey Muraviov

Attachment Content-Type Size
psql-wrapped-expanded-fix-v4.patch text/x-patch 57.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-05-18 18:49:10 Re: buildfarm: strange OOM failures on markhor (running CLOBBER_CACHE_RECURSIVELY)
Previous Message Thomas Munro 2014-05-18 13:16:30 Re: SKIP LOCKED DATA (work in progress)