Re: Wrong results in remove_useless_groupby_columns()

From: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong results in remove_useless_groupby_columns()
Date: 2026-05-08 02:57:45
Message-ID: CAJTYsWXpUzj3hn7RZi30t57gQ499JSp=2oW8AVOqJA=WZ_YLCw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Fri, 8 May 2026 at 05:46, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:

> On Tue, May 5, 2026 at 7:12 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > Attached patch fixes both issues.
>
> I plan to push and back-patch this shortly, as the code freeze for the
> stable branches is just around the corner.
>
> - Richard
>
>
I reviewed the patch and it looks good to me.

The added opfamily and collation checks seem consistent with the uniqueness
proof used in relation_has_unique_index_for(), and the tests cover both
reported wrong-result cases.

Applied the patch, ran tests, they passed.

Regards,
Ayush

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2026-05-08 02:58:17 Re: Proposal: Conflict log history table for Logical Replication
Previous Message cca5507 2026-05-08 02:34:56 Re: Call EndCopyFrom() after initial table sync in logical replication