| From: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Alexander Lakhin <exclusion(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: 041_checkpoint_at_promote.pl might fail due to race condition on child kill |
| Date: | 2026-10-30 06:58:51 |
| Message-ID: | CAJTYsWXkw4OqxNKVrp8dkhJjG8huFyvCjxEvSL7imSFembaP_g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, 13 Oct 2026 at 12:47, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Fri, Oct 9, 2026 at 4:00 AM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
> > Your patch works for me test-wise. The same test loop passed 100+
> > iterations successfully. Thank you for paying attention to this!
>
> Thanks for the test!
>
> On second thought, we can simplify the test by waiting for the postmaster to
> log "all server processes terminated; reinitializing" instead of using
> another backend connection to detect the crash. This ensures that the
> postmaster has detected the crash and started restarting. The attached
> patch takes this approach. Thoughts?
Thanks for the patch.
Did multiple runs with it, and the changes lgtm.
Regards,
Ayush
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeevan Chalke | 2026-10-30 06:59:41 | PL/pgSQL: "missing X at end of SQL expression" is never reported at end of input |
| Previous Message | Chao Li | 2026-10-30 06:54:34 | Re: Fix error handling in pg_flush_data() and FilePrefetch() |