Re: [BUG] ON CONFLICT DO UPDATE SET x = EXCLUDED.<virtual-generated-column> errors or silently writes NULL

Hi,

On Fri, 11 Sept 2026 at 09:30, Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
>
> Hello Dean and Satyanarayana,
>
> 22.04.2026 11:12, Dean Rasheed wrote:
>
> On Mon, 20 Apr 2026 at 01:55, SATYANARAYANA NARLAPURAM
> <satyanarlapuram(at)gmail(dot)com> wrote:
>
> Reran the failing tests and they all passed. Additionally ran the regression tests.
> Patch looks good to me.
>
> Thanks for checking. Patch pushed and back-patched to v18.
>
>
> Please look at a case broken by 783425175:
> CREATE TABLE t (id int PRIMARY KEY, c int GENERATED ALWAYS AS (tableoid));
> INSERT INTO t VALUES (1) ON CONFLICT (id) DO UPDATE SET id = 1 WHERE excluded.c > 0;
>
> ERROR: XX000: variable not found in subplan target lists
> LOCATION: fix_join_expr_mutator, setrefs.c:3229

Thanks for the report.

ISTM virtual generated column is expanded to the tableoid reference, but the
EXCLUDED target list has no tableoid entry for setrefs.c to resolve.

Attached patch adds that entry and the statement you sent works fine with it.

Thoughts?

Regards,
Ayush