| From: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Richard Guo <guofenglinux(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, Jacob Brazeal <jacob(dot)brazeal(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, underdog(at)theori(dot)io |
| Subject: | Re: remove_useless_joins vs. bug #19560 |
| Date: | 2026-09-29 14:10:07 |
| Message-ID: | CAJTYsWX=HBovk2FDzA_MbR986rETW93BGR+G+8X=TN1W37oJ4Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Sun, 27 Sept 2026 at 22:02, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> I wrote:
> > Concretely, about like this. This fixes the given reproducer.
> > I've not put thought into what sort of test cases we might want
> > to add.
>
> Now with test cases, a commit message explaining why do it like
> this, and a bit of additional comment-polishing.
Thanks for the patch.
I went through v1. Grouping the SJE candidates by checkAsUser
looks right to me, including the unset case. I didn't spot any
issues. LGTM.
Regards,
Ayush
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2026-09-29 14:24:23 | Re: [PATCH] Fix TAP tests with recent IPC::Run on Windows |
| Previous Message | Xuneng Zhou | 2026-09-29 14:08:28 | Re: test: avoid redundant standby catchup in 049_wait_for_lsn |