Re: [PATCH] Fix stale relation close in sequence synchronization

From: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Ajin Cherian <itsajin(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Fix stale relation close in sequence synchronization
Date: 2026-05-01 05:15:20
Message-ID: CAJTYsWW8QdW7cFfWUGsoOMRpR-s2PB39cZZ=dv5vibtdeqErFw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Fri, 1 May 2026 at 09:54, vignesh C <vignesh21(at)gmail(dot)com> wrote:

> On Fri, 1 May 2026 at 08:58, Ajin Cherian <itsajin(at)gmail(dot)com> wrote:
> >
> > This seems to be causing the below buildfarm failure:
> >
> >
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=drongo&dt=2026-04-30%2018%3A50%3A23
>
> Thanks for reporting this, we are analyzing this. We will analyze and
> propose a patch for the same.
>
>
From what I see it the failure is
not in the sequence-copy logic itself. It happens before
the test reaches the privilege check: after the test
switches the subscription connection to user=regress_seq_repl,
Windows tries SSPI auth for that login role and rejects it.

I could not run a native Windows SSPI test locally,
but this follows the existing TAP harness pattern
used by tests that authenticate as non-default roles.
The failure occurs because regress_seq_repl is used in
the subscription connection string but is not passed via
auth_extra, so pg_regress --config-auth does not add a
Windows SSPI ident mapping for it.

Meanwhile I'll try to set up a windows machine
and run the test

meson test -C build subscription/036_sequences --print-errorlogs --verbose

Regards,
Ayush

Attachment Content-Type Size
0001-Fix-Windows-SSPI-auth-in-sequence-subscription-test.patch application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2026-05-01 05:53:18 Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Previous Message Michael Paquier 2026-05-01 04:30:29 Re: Having problems generating a code coverage report