Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: JoongHyuk Shin <sjh910805(at)gmail(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Date: 2026-05-01 05:53:18
Message-ID: CAHGQGwF24XMh=35m+FdqLUw4QgK8HmAGwPZyBDKtsw7MWYp_hw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 29, 2026 at 6:30 PM JoongHyuk Shin <sjh910805(at)gmail(dot)com> wrote:
>
> Thanks for the reviews.
>
> v2 attached.

Thanks for updating the patch!

When I started postgres with the following command, recovery_target_xid was
treated as unset in the master, but with the patch the recovery_target_xid=700
setting was used instead. This behavior seems unexpected to me. Thoughts?

postgres -D data -c "recovery_target_xid=700" -c "recovery_target_xid="

Regards,

--
Fujii Masao

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2026-05-01 06:17:05 Re: [PATCH] Fix stale relation close in sequence synchronization
Previous Message Ayush Tiwari 2026-05-01 05:15:20 Re: [PATCH] Fix stale relation close in sequence synchronization