Re: [PATCH] postmaster: fix stale PM_STARTUP comment

On Tue, 21 Apr 2026 at 06:30, Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> On Mon, Apr 20, 2026 at 12:11:45PM +0530, Ayush Tiwari wrote:
>
> No need to. I have poked at this problem a bit more, stracing my way
> as you did, and after more testing across v15~HEAD, I have applied it.
> For v15, a difference becomes necessary at HandleChildCrash(), or we
> would begin to fail the shutdown sequence should the startup process
> have the idea to PANIC. This maps with the changes in v18 and HEAD
> where this has been replaced by a switch/case.
>
> Another thing that I have spent a long time looking at is
> process_pm_child_exit() and the interference that this could generate
> for the startup process case, but here as well I did not spot any
> issue, so I think that we are in the clear.
>
> There was also a comment at the top of postmaster.c that incorrectly
> claimed that the checkpointer and the background writer were only
> started after switch to PM_RECOVERY, which was wrong. I have tweaked
> that while on it.
>
> That was a good catch overall.
>
>
Thanks a lot Michael for looking into it and pushing it!

Regards,
Ayush