| From: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Remove the refint contrib module (for v20) |
| Date: | 2026-06-29 04:41:06 |
| Message-ID: | CAJTYsWVofHXC_uPoE_qUCprH=RseLkNHbJyHDH5Jfxf02AErCA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Mon, 29 Jun 2026 at 00:29, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> > On 28 Jun 2026, at 10:14, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> > The doc patch says that Postgres 19 shipped a contrib module named
> > refint, but that's not fully correct. It shipped an *extension* named
> > refint inside the contrib module named spi. I think that wording could
> > be improved.
>
> Agreed.
>
> + trigger functions <function>check_primary_key()</function> and
>
> We also typically don't append parentheses to function names in the docs.
>
Thanks for the review!
Attaching patch with improved wording and parentheses
changes.
Basic git diff between v3 and v4:
- <title>refint Module Removed</title>
+ <title>refint Extension Removed</title>
- PostgreSQL 19 and below shipped a
- contrib module named refint that provided the
- trigger functions check_primary_key() and
- check_foreign_key() as an early way to enforce
+ PostgreSQL 19 and below shipped an
+ extension named refint, part of the
+ spi contrib module, providing the trigger
+ functions check_primary_key and
+ check_foreign_key as an early way to enforce
- ...), and the module was removed
+ ...), and the extension was removed
Regards,
Ayush
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Remove-the-refint-contrib-module.patch | application/octet-stream | 39.9 KB |
| v4-0002-Handle-refint-removal-in-cross-version-pg_upgrade.patch | application/octet-stream | 1.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | JoongHyuk Shin | 2026-06-29 04:45:37 | Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks |
| Previous Message | cca5507 | 2026-06-29 04:37:39 | Re: Handle concurrent drop when doing whole database vacuum |