Re: Remove the refint contrib module (for v20)

Hi,

On Mon, 29 Jun 2026 at 11:53, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> On Sat, Jun 6, 2026 at 4:28 AM Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
> wrote:
> > 0002 (test-only) teaches AdjustUpgrade.pm to drop the refint
> > extension and its leftover tables (pkeys, fkeys, fkeys2) from
> > contrib_regression_spi / regression_spi when upgrading from a version
> > that still shipped refint, so cross-version pg_upgrade tests don't
> > fail dump comparison once v20 opens.
> > I followed the existing < 19 btree_gist block style.
>
> In make-based contrib tests with USE_MODULE_DB=1, contrib/spi uses
> contrib_regression_autoinc database, since autoinc is the first entry
> in MODULES. So, in 0002 patch, shouldn't we also remove
> the refint-related objects from contrib_regression_autoinc?
>

Thanks for the review, Fujii-san!

Yes, you are right, I missed removing that in 0002 patch.

v5-0001 is identical to v4-0001.

Adding you suggested changes, in v5.

Regards,
Ayush

>