| From: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Table sync race with REFRESH PUBLICATION |
| Date: | 2026-09-29 04:44:43 |
| Message-ID: | CAJTYsWVF-rr4mdtck5Bx_MwH=VhKuPPFc+UVVL0nV1JnJrEQog@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, 29 Sept 2026 at 07:30, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> > Attached is v2 with those changes. Thoughts?
> >
>
> Hi Ayush.
>
> //////////
> Patch v2-0001
> //////////
>
> Patch 0001 looks good to me, but more eyes than mine need to review it.
Thanks for the review!
>
> //////////
> Patch v2-0002
> //////////
>
> I confirmed the test fails when patch 0001 is not applied and passes
> when it is applied.
>
> I assume the test code is AI-generated, because it looks way less
> human-readable than a typical TAP test. If the test is ever intended
> to be pushed, then it needs lots of comments to describe what it is
> doing and expecting at each step.
I do not intend this to be pushed since as I stated upthread its
a niche case that came out of manual review rather than field report.
I'll post a simplified version in some time for the same, thanks
for looking into it.
Regards,
Ayush
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikhil Kumar Veldanda | 2026-09-29 05:11:45 | Re: ZSTD TOAST compression, and an extensible compression method encoding |
| Previous Message | Chee Wooson | 2026-09-29 04:44:24 | Re: Re: [PATCH] Discard aborted updaters when expanding a multixact |