| From: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: plpython: NULL pointer dereference on broken sequence objects |
| Date: | 2026-06-26 07:22:37 |
| Message-ID: | CAJTYsWV4PhH=mhs9KuTLyL4YSOfbuUM1E22K91osDQVsxQu-Og@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, 26 Jun 2026 at 11:35, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Thu, Jun 25, 2026 at 10:05 PM Ayush Tiwari
> <ayushtiwari(dot)slg01(at)gmail(dot)com> wrote:
> > I think there's a similar problem on the mapping side that v1 doesn't
> > cover. PLyMapping_ToJsonbValue and the hstore equivalent fetch items with
> > PyMapping_Items() and PyList_GetItem() without checking for NULL, and a
> > mapping whose items() raises still would crash the backend.
>
> Right. Those functions have the same issue as PySequence_GetItem().
> The attached v2 patch fixes them all.
>
Thanks for the update! v2 LGTM.
Regards,
Ayush
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-06-26 08:12:15 | Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks |
| Previous Message | Kyotaro Horiguchi | 2026-06-26 07:15:53 | Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks |