Re: Incorrect check in 037_except.pl?

From: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Incorrect check in 037_except.pl?
Date: 2026-07-22 13:37:51
Message-ID: CAJTYsWUk+5m8jjGrxKT5zMZT2O2DHQLARXYzGy-0tzbM2yCUqA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, 22 Jul 2026 at 18:29, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> Hi,
>
> $result =
> $node_publisher->safe_psql('postgres', "SELECT * FROM tab1 ORDER BY
> a");
> is( $result, qq(1
> 2),
> "check replication of a table in the EXCEPT clause of one
> publication but included by another"
> );
>
> In 037_except.pl, this query is executed on the publisher. But,
> if the intent is to verify that rows inserted on the publisher are
> replicated to the subscriber, shouldn't this query be executed on
> the subscriber instead? IOW, should "$node_publisher" here be
> "$node_subscriber"? Or am I missing something?
>

Yeah you're right, it should likely be the subscriber.

Same issue appears twice (the "FOR TABLE" and "FOR ALL TABLES" cases);
both need the change.

Regards,
Ayush

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-07-22 13:38:23 Re: Fix "unexpected logical decoding status change" error; from concurrent logical decoding activation
Previous Message Nathan Bossart 2026-07-22 13:31:49 Re: convert various variables to atomics