| From: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
|---|---|
| To: | Yuefei Shi <shiyuefei1004(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Backup manifests accept out-of-range LSNs |
| Date: | 2026-08-12 09:27:33 |
| Message-ID: | CAJTYsWU-QKtvi8aNch9XwkUO+MaK8kBAG+B9Tk2TKYHATtzbuA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Thu, 6 Aug 2026 at 07:22, Yuefei Shi <shiyuefei1004(at)gmail(dot)com> wrote:
> Reviewed this patch.
>
> The issue seems valid. PostgreSQL-generated manifests should not normally
> contain such LSNs, but a malformed or modified manifest could make the
> parser operate on a different LSN than the one specified. The current
> sscanf() based parser allows this through truncation of oversized
> components and ignored trailing characters.
>
> The proposed fix looks good and the tests cover the regression cases.
>
Thanks for the review!
Attaching v2 which uses the new pg_parse_lsn funct.
Regards,
Ayush
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Reject-out-of-range-LSNs-in-backup-manifests.patch | application/octet-stream | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Quan Zongliang | 2026-08-12 09:31:15 | Re: [PATCH] Remove stale comment and dead store in BuildTupleHashTable |
| Previous Message | shveta malik | 2026-08-12 09:10:29 | Re: Support EXCEPT for TABLES IN SCHEMA publications |