Re: Backup manifests accept out-of-range LSNs

From: Yuefei Shi <shiyuefei1004(at)gmail(dot)com>
To: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: Backup manifests accept out-of-range LSNs
Date: 2026-08-06 01:52:40
Message-ID: CAD43U4UQCJ6NsF8Du_v11nA1rGn_O1P+a2gc420NhRy3XfOKfg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Reviewed this patch.

The issue seems valid. PostgreSQL-generated manifests should not normally
contain such LSNs, but a malformed or modified manifest could make the
parser operate on a different LSN than the one specified. The current
sscanf() based parser allows this through truncation of oversized
components and ignored trailing characters.

The proposed fix looks good and the tests cover the regression cases.

>

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Fujii Masao 2026-08-06 01:43:21 Re: Fix archive restore race that could unlink WAL before rename