| From: | Robert Treat <rob(at)xzilla(dot)net> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Daniel Bauman <danielbaniel(at)gmail(dot)com>, Zhenwei Shang <a934172442(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Doc update proposal for the note on log_statement in the runtime config for logging page |
| Date: | 2026-08-14 19:11:31 |
| Message-ID: | CAJSLCQ1A4icmOB2bP1Weyni1T2vgDOUVqALFX8dSsmpQU3iifg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 14, 2026 at 2:24 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> On Fri, Aug 14, 2026 at 01:24:46PM -0400, Robert Treat wrote:
> > I think there's general agreement that these changes help clarify both
> > the intent and the real world operation of the logging collector. I
> > played around with the wording a little, but I couldn't find anything
> > that seemed markedly better, so outside of some small kibitzing (line
> > wrapping, maybe some commas) I think this is probably ready for
> > commit, and I've marked it as such in the commitfest.
>
> How about something like this?
>
> The logging collector is designed to avoid dropping messages. This
> means that in case of extremely high load, server processes could be
> blocked while trying to send additional log messages when the collector
> has fallen behind. In contrast, syslog prefers to drop messages if it
> cannot write them, which means it may fail to log some messages in such
> cases but it will not block the rest of the system.
>
> The logging collector does not guarantee that log messages have reached
> durable storage. It can still lose messages due to a system crash,
> power loss, or an error while writing the log file.
>
> IMHO the overall style of this section still has some room for improvement,
> but I think it gets the point across well enough.
>
+1
Robert Treat
https://xzilla.net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-08-14 19:36:09 | basebackup: do not verify checksums on pages written before enabling checksums |
| Previous Message | Sami Imseih | 2026-08-14 19:08:20 | Re: pgstat: Flush some statistics within running transactions, take 2 |