| From: | Andrew Borodin <borodin(at)octonica(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Sergey Mirvoda <sergey(at)mirvoda(dot)com> |
| Subject: | Re: Re: GiST optimizing memmoves in gistplacetopage for fixed-size updates [PoC] |
| Date: | 2016-07-26 08:23:15 |
| Message-ID: | CAJEAwVHhaieEK3A7PsGunDJMfH6vLPVKKwZAjSuK4zH-cFhMXg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>Can you please patch BRIN to use this new function too?
On my machine replacement of both BRIN update cases (see
https://github.com/x4m/pggistopt/commit/a6d301ff79104b977619339d53aebf748045418a
) showed no performance changes on folowing update query (6 seconds of
updates avg):
create table dataTable(x int, y int);
insert into dataTable(x,y) select x,y from generate_series(1,1e3,1)
x,generate_series(1,1e3,1) y;
create index idx on dataTable using brin(x,y);
update datatable set x = random()*1024, y = random()*1024;
https://gist.github.com/x4m/7e69fd924b9ffd2fdc9c6100e741171d
Probably I was looking in a wrong place. I do not see other cases when
PageIndexTupleOverwrite can improve performance of BRIN. Though I'll
make PageIndexTupleOverwrite BRIN-compatible in forthcoming patch
version: BRIN tuples have no length in header and it must be taken as
a parameter. Just as the PageAddItem do.
Best regards, Andrey Borodin, Octonica & Ural Federal University.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2016-07-26 08:54:54 | Re: No longer possible to query catalogs for index capabilities? |
| Previous Message | Bjorn Munch | 2016-07-26 08:19:13 | Re: fixes for the Danish locale |