| From: | Daniil Davydov <3danissimo(at)gmail(dot)com> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Typos in the code and README |
| Date: | 2026-04-20 06:11:48 |
| Message-ID: | CAJDiXggv2M724eyHkUQqPiC3jjNmB0uOTh0utSbzFqAdiA_U0g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Mon, Apr 20, 2026 at 2:00 AM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
>
> Please look at another set of typos and inconsistencies introduced since
> 2026-01-01
I've found a few other typos. Although they are quite old, I think they should
be mentioned here :
1) Typo in tidstore.c
"Find the shared the shared radix tree" --> "Find the shared radix tree".
2) A bit inconsistent comment in twophase.c
```
/*
* Recreates a state file. This is used in WAL replay and during
* checkpoint creation.
*
* Note: content and len don't include CRC.
*/
static void
RecreateTwoPhaseFile(FullTransactionId fxid, void *content, int len)
```
This comment was introduced in the implementation of the two-phase commit [1].
At that time, this function was actually used during replaying the
XLOG_XACT_PREPARE record. Commit [2] changed that code, so now this function is
used only during checkpoint and restartpoint creation.
If restartpoint creation can be considered as part of the WAL replay, we can
leave this comment as is. Otherwise, I suggest changing it to something like
this :
/*
* Recreates a state file. This is used during checkpoint/restartpoint creation.
*
* Note: content and len don't include CRC.
*/
Another idea - we can stop listing the places of function's usage so that we
don't need to touch this comment later.
[1] d0a89683a3a4dd8e76ef0a99101355999e519df5
[2] 728bd991c3c4389fb39c45dcb0fe57e4a1dccd71
--
Best regards,
Daniil Davydov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chengpeng Yan | 2026-04-20 06:17:47 | Re: [PATCH] Fix hashed ScalarArrayOp semantics for NULL LHS with non-strict comparators |
| Previous Message | Ayush Tiwari | 2026-04-20 06:08:49 | Re: [BUG] Race in online checksums launcher_exit() |