| From: | Daniil Davydov <3danissimo(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Sami Imseih <samimseih(at)gmail(dot)com>, Matheus Alcantara <matheusssilv97(at)gmail(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: POC: Parallel processing of indexes in autovacuum |
| Date: | 2026-04-04 08:37:55 |
| Message-ID: | CAJDiXggPFohjMA1XKJrpR7=UpTeDCzzObTYoPUkDid+4+Vhn0w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Sat, Apr 4, 2026 at 8:12 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> Regarding the regression tests, ISTM we no longer need
> 'autovacuum-leader-before-indexes-processing' injection point since it
> currently tests that parallel workers update their delay parameters
> during the initialization (i.e., in parallel_vacuum_main()). In order
> to verify the behavior of workers updating their delay parameters
> while processing indexes, we would need another injection ponit to
> stop parallel workers, which seems overkill to me. So I removed it but
> the test still covers the propagation logic.
>
> Regarding the patch, I don't think it's a good idea to include
> bgworker_internals.h from reloptions.c:
>
> I'd leave the maximum value as 1024.
OK, let's leave it.
>
> I've attached patch and please check it. I think it's a good shape and
> I'm going to push it next Monday barrying objections.
>
Thank you for updating the patch!
All changes look good to me.
BTW, what about the "opt-in vs. opt-out style" issue?
As I wrote here [1], we can consider a new approach - allow the user to set the
autovacuum_max_workers reloption even if GUC parameter is zero.
I think it can satisfy all possible use cases.
--
Best regards,
Daniil Davydov
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2026-04-04 08:50:14 | Re: Adding REPACK [concurrently] |
| Previous Message | Lukas Fittl | 2026-04-04 08:11:25 | Re: pg_plan_advice |