Re: Add PGDLLIMPORT lines to some variables

From: Brian Cloutier <brian(at)citusdata(dot)com>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Add PGDLLIMPORT lines to some variables
Date: 2017-11-20 19:58:44
Message-ID: CAJCy68cs0oHLp0o5PSEEUQBNkcwrTpFPvxeQcxCRoBo8oZxMgw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> please, append session_timezone to your list

Here's a v2 patch which also includes session_timezone.

Separately, is this the kind of thing which is eligible for backporting
into the next releases of 9.6 and 10?

On Thu, Nov 16, 2017 at 10:27 PM, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
wrote:

> Hi
>
> 2017-11-16 23:59 GMT+01:00 Brian Cloutier <brian(at)citusdata(dot)com>:
>
>> Hello hackers,
>>
>> I'm porting Citus to Windows and found that we use some variables which
>> PG doesn't export; here is a patch which adds PGDLLIMPORT declarations to
>> those variables. This is unfortunately required on Windows for extensions
>> to be able to use those variables, and appears to already have been done to
>> quite a few other variables.
>>
>
> please, append session_timezone to your list
>
> Regards
>
> Pavel
>
>

Attachment Content-Type Size
pgdllimport-v2.patch text/x-patch 6.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-11-20 20:02:30 Re: Add PGDLLIMPORT lines to some variables
Previous Message Tom Lane 2017-11-20 19:53:24 Re: Using isatty() on WIN32 platform