| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | John Naylor <johncnaylorls(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Refactor bytea_sortsupport(), take two |
| Date: | 2025-11-27 12:45:15 |
| Message-ID: | CAJ7c6TPyagp4p3781MqfDTDcsOSowwHR5RSpt-nrfF-jAMWmhA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi John,
> How about this:
>
> "Short byteas will have terminating NUL bytes in the abbreviated
> datum. Abbreviated comparison need not make a distinction between
> thse NUL bytes, and NUL bytes representing actual NULs in the
> authoritative representation." [...]
>
> After that, the rest seems to flow better at a quick glance.
Yes, it is much better now, thanks! Previously the comment was
reasoning about NUL bytes as if normally bytea can't have them which
IMO was confusing.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Refactor-bytea_sortsupport.patch | text/x-patch | 13.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2025-11-27 12:46:09 | Re: Import Statistics in postgres_fdw before resorting to sampling. |
| Previous Message | Álvaro Herrera | 2025-11-27 12:32:44 | Re: Issues with ON CONFLICT UPDATE and REINDEX CONCURRENTLY |