| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Sven Klemm <sven(at)timescale(dot)com> |
| Subject: | Re: [PATCH] Allow CustomScan nodes to signal projection support |
| Date: | 2021-05-03 13:18:19 |
| Message-ID: | CAJ7c6TPu2T8gWZ+tF1WqXdFcvxsSfWFPtC1fciKqbOCsriC1mg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Sven,
> The attached patch allows CustomScan nodes to signal whether they
> support projection.
I noticed that you didn't change custom-scan.sgml accordingly. The
updated patch is attached. Otherwise, it seems to be fine in terms of
compiling, passing tests etc.
> I named the flag CUSTOMPATH_SUPPORT_PROJECTION similar to the other
> custom node flags, but this would revert the current logic
This seems to be a typical Kobayashi Maru situation, i.e any choice is
a bad one. I suggest keeping the patch as is and hoping that the
developers of existing extensions read the release notes.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-costumscan_projection_flag.patch | application/octet-stream | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-05-03 13:20:54 | Re: Replication slot stats misgivings |
| Previous Message | vignesh C | 2021-05-03 13:11:15 | Re: Enhanced error message to include hint messages for redundant options error |