| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, John Naylor <johncnaylorls(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Simplify SortSupport implementation for macaddr |
| Date: | 2026-03-09 13:08:06 |
| Message-ID: | CAJ7c6TPoPMfGwVuM14T7KuWVcRaoE3-nd3goLoE5zss4JzAExw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Andrey,
Many thanks for your feedback!
> 1. The assignment ssup->ssup_extra = NULL can be removed. The
> SortSupport struct is zeroed before the callback is called (see
> sortsupport.h). There are about 22 similar assignments elsewhere;
> it does not seem to be established practice, many other places have
> no such assignment.
Agree. I removed this assignment in 0001 and added 0002 that removes
if for the rest of *_sortsupport() functions.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-Remove-redundant-ssup_extra-zeroing-in-_sortsuppo.patch | text/x-patch | 9.9 KB |
| v2-0001-Simplify-SortSupport-implementation-for-macaddr.patch | text/x-patch | 6.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-03-09 13:08:08 | Re: Consider low startup cost in add_partial_path |
| Previous Message | Robert Haas | 2026-03-09 13:07:47 | Re: pg_combinebackup: incorrect size of VM fork after combine |