Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Cc: Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Alexander Korotkov <akorotkov(at)postgresql(dot)org>
Subject: Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback
Date: 2025-05-07 10:35:01
Message-ID: CAJ7c6TPkaYo12pycMfhEbFd7DdQP8URVvAdAFFnagWhuncmUsg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

> OK, now I get your point: you think this should go to the next major
> release. But no, it's not. It's intended to eventually land into
> REL_18_STABLE, REL_18_BETA2 etc. It addresses one of PG18 Open Items:
> Richard Guo found the way SJE changes ChangeVarNodes() unsatisfiable,
> and this commit is intended to fix that. Also, note that it is not
> the only PG18 Open Item left after beta1, and fixing Open Items
> usually requires changes besides docs and whitespaces.

Now I get it. From the commit message it looked like a regular
refactoring. I didn't realize it fixes an open item.

Many thanks!

--
Best regards,
Aleksander Alekseev

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2025-05-07 18:37:52 pgsql: pg_dumpall: Add --sequence-data.
Previous Message Alexander Korotkov 2025-05-07 10:25:49 Re: pgsql: Refactor ChangeVarNodesExtended() using the custom callback