| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Several refactorings for pg_dump |
| Date: | 2026-08-20 12:53:26 |
| Message-ID: | CAJ7c6TPeN89RNAr_BiF4ds-+a5m4GnjjnFx11rFdf=jKN-OTrA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Daniel,
> I'm not sure that using TAR_BLOCK_SIZE is preferred for
> a lookahead buffer used to identify the archive format where tar is just one of
> the options.
>
> I would be more inclined to initialize .lookaheadSize like today and then use
> that instead of the hardcoded 512. Having a buffer in ArchiveHandle without
> knowing the size of it does seem like a bad practice even if nothing uses it
> today.
Sounds good. Here is the patch v2.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pg_dump-use-ArchiveHandle.lookaheadSize-instead-o.patch | text/x-patch | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Nidzwetzki | 2026-08-20 13:31:53 | Re: Enable partitionwise join for partition keys wrapped by RelabelType |
| Previous Message | Robert Treat | 2026-08-20 12:52:36 | Re: typo in postgres-fdw.sgml - Re: pgsql: postgres_fdw: push down FUNCTION RTE into foreign joins |