| From: | Robert Treat <rob(at)xzilla(dot)net> |
|---|---|
| To: | Erik Rijkers <er(at)xs4all(dot)nl> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
| Subject: | Re: typo in postgres-fdw.sgml - Re: pgsql: postgres_fdw: push down FUNCTION RTE into foreign joins |
| Date: | 2026-08-20 12:52:36 |
| Message-ID: | CABV9wwOvWbeGoi4XRkujgD5niC6tcAHMxQ61=KeL-rErFeNRcA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Aug 19, 2026 at 8:32 PM Erik Rijkers <er(at)xs4all(dot)nl> wrote:
>
> Op 8/19/26 om 12:49 schreef Alexander Korotkov:
> > postgres_fdw: push down FUNCTION RTE into foreign joins
> >
> > A foreign join planning hook now considers a (foreign-table x function-RTE)
> > INNER join as a push-down candidate when the function >
> ...
> > Branch
> > ------
> > master
> >
> > Details
> > -------
> > https://git.postgresql.org/pg/commitdiff/0ee83dd4a9940883b5241fc9c80fd27f63f2e47f
> >
> > Modified Files
> > --------------
> > contrib/postgres_fdw/deparse.c | 157 +++++-
> > contrib/postgres_fdw/expected/postgres_fdw.out | 627 ++++++++++++++++++++++++
> > contrib/postgres_fdw/postgres_fdw.c | 642 +++++++++++++++++++++++--
> > contrib/postgres_fdw/postgres_fdw.h | 12 +
> > contrib/postgres_fdw/sql/postgres_fdw.sql | 274 +++++++++++
> > doc/src/sgml/postgres-fdw.sgml | 18 +
> > src/backend/optimizer/util/relnode.c | 25 +
> > 7 files changed, 1698 insertions(+), 57 deletions(-)
>
> Hi,
>
> in: doc/src/sgml/postgres-fdw.sgml, I believe this sentence:
>
> "and none of the following disqualifying conditions applies:"
>
> should be:
>
> "and none of the following disqualifying conditions apply:"
>
> Please, can a native English speaker confirm?
>
+1. to the above. FWIW, the rest of the original patch seems fine.
Robert Treat
https://xzilla.net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2026-08-20 12:53:26 | Re: [PATCH] Several refactorings for pg_dump |
| Previous Message | Heikki Linnakangas | 2026-08-20 12:50:04 | Re: Make formatting.c use StringInfos for output buffers |
| From | Date | Subject | |
|---|---|---|---|
| Previous Message | Heikki Linnakangas | 2026-08-20 08:56:09 | pgsql: Skip bogus find_composite_type_dependencies() call on sequences |