Re: XLogCtl->ckptFullXid is unused

From: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Subject: Re: XLogCtl->ckptFullXid is unused
Date: 2025-07-11 21:32:31
Message-ID: CAJ7c6TPUnfaNV5rWoh_qzT7uo7ZHX-pvNRj+Y6LbEkfELN1gRA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Nathan,

> I just noticed $SUBJECT. This seems to be an oversight in commit 2fc7af5,
> which simultaneously combined ckptXidEpoch and ckptXid into ckptFullXid
and
> removed the only use of that information, i.e., GetNextXidAndEpoch(). Any
> objections if I remove it now?

Good catch. I don't see any reason why we might want to keep ckptFullXid.
Also I checked if there are any references left to this field - there are
none.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nathan Bossart 2025-07-11 21:58:30 Re: Improve LWLock tranche name visibility across backends
Previous Message Sami Imseih 2025-07-11 21:32:13 Re: Improve LWLock tranche name visibility across backends