Re: [PATCH] Remove workarounds to format [u]int64's

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Japin Li <japinli(at)hotmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
Subject: Re: [PATCH] Remove workarounds to format [u]int64's
Date: 2022-03-21 10:55:44
Message-ID: CAJ7c6TPSSWDdYJq3E9dqurzxWfnEd2pB9ZBSFVaQ_YqLbE5OxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Japin,

> After apply the patch, I found pg_checksums.c also has the similar code.

Thanks for noticing it.

> In progress_report(), I'm not sure we can do this replace for this code.

I added the corresponding change as a separate commit so it can be
easily reverted if necessary.

Here is a complete patchset with some additional changes by me.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
v3-0001-Remove-workarounds-to-format-u-int64-s.patch application/octet-stream 11.9 KB
v3-0002-Remove-workarounds-to-format-int64-s-in-pg_checks.patch application/octet-stream 12.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-03-21 11:24:38 Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Previous Message Arne Roland 2022-03-21 10:50:46 Re: Detaching a partition with a FK on itself is not possible