| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Cc: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Online enabling and disabling of data checksums |
| Date: | 2026-04-06 14:39:04 |
| Message-ID: | CAJ7c6TPRTnQFXXX1CRcYoTLXw2swtDH==uSz1MYoMKdLrKZHjA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi Daniel,
> Online enabling and disabling of data checksums
>
> [...]
I noticed a little mistake:
```
/*
* Await state transition to "on" in all backends. When done we know that
* data data checksums are both written and verified in all backends.
*/
```
The word "data" is repeated twice.
Also there are inconsistencies in the way
XLogCtlData->data_checksum_version,
ControlFileData->data_checksum_version and certain variables are
assigned. Sometimes a hardcoded 0 is used and sometimes
PG_DATA_CHECKSUM_OFF. I suggest using values of the enum
ChecksumStateType for readability / consistency.
Here are corresponding patches.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0002-Use-PG_DATA_CHECKSUM_OFF-instead-of-hardcoded-zer.patch | text/x-patch | 6.6 KB |
| v1-0001-Fix-doubled-word-in-a-comment-introduced-by-commi.patch | text/x-patch | 1003 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-04-06 14:50:43 | pgsql: Add TAP tests for log_lock_waits |
| Previous Message | Fujii Masao | 2026-04-06 14:05:37 | pgsql: Release postmaster working memory context in slotsync worker |