| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Junwang Zhao <zhjwpku(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH v1] eliminate duplicate code in table.c |
| Date: | 2022-07-21 11:39:33 |
| Message-ID: | CAJ7c6TPMJP6PtoS3byPZ-s_U4bV-sfbDA0RzzPzM3UQRwctLaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
> > There are some duplicate code in table.c, add a static inline function
> > to eliminate the duplicates.
> >
>
> Can we name function as validate_object_type, or check_object_type?
>
> Otherwise, the patch looks fine to me. Let's see if others have
> something to say.
LGTM
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Eliminate-duplicate-code-in-table.c.patch | application/octet-stream | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-07-21 11:42:19 | Re: Use extended statistics to estimate (Var op Var) clauses |
| Previous Message | Andrey Lepikhov | 2022-07-21 11:35:49 | Re: [PoC] Reducing planning time when tables have many partitions |