| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | [PATCH] dynahash.c refactoring |
| Date: | 2026-10-29 11:03:55 |
| Message-ID: | CAJ7c6TPGc1eXGp+tzjfVBZnSCmYkdMozKaGxDhVaw5xHdGaeUA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
0001: hash_freeze() has not been used since 5dfc198146 (Oct 2016). I
suggest removing it.
0002: hash_destroy() is the only caller of hash_stats(). I suggest
making the function static and place it under `#ifdef
HASH_STATISTICS`.
Thoughts?
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0002-Make-hash_stats-static.patch | text/x-patch | 3.0 KB |
| v1-0001-Remove-hash_freeze.patch | text/x-patch | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Jones | 2026-10-29 11:11:37 | Uncancellable infinite loop in xpath() with entity references |
| Previous Message | Jehan-Guillaume de Rorthais | 2026-10-29 10:52:21 | PGC_S_ARGV vs pg_file_settings and pg_settings |