Re: Table AM modifications to accept column projection lists

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Cc: Jacob Champion <pchampion(at)vmware(dot)com>, "zyu(at)yugabyte(dot)com" <zyu(at)yugabyte(dot)com>, "pryzby(at)telsasoft(dot)com" <pryzby(at)telsasoft(dot)com>, "hlinnaka(at)iki(dot)fi" <hlinnaka(at)iki(dot)fi>, "sawada(dot)mshk(at)gmail(dot)com" <sawada(dot)mshk(at)gmail(dot)com>, "soumyadeep2007(at)gmail(dot)com" <soumyadeep2007(at)gmail(dot)com>, "Ashwin Agrawal (Pivotal)" <aagrawal(at)pivotal(dot)io>, "melanieplageman(at)gmail(dot)com" <melanieplageman(at)gmail(dot)com>
Subject: Re: Table AM modifications to accept column projection lists
Date: 2021-06-01 12:38:33
Message-ID: CAJ7c6TPAiWqT1cePzHXEKp2Jt8fwNbfstR3ZHnsOU_jNzanuAA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Soumyadeep, Jacob,

> Thanks for the review!

I came across this patch and noticed that it rotted a little, especially
after removing inheritance_planner() in 86dc9005. I managed to resolve the
conflicts on current `master` (eb89cb43), see the attached patch. The code
compiles but doesn't pass the tests. I'm currently in the process of
reviewing it and didn't figure out what the issue is yet. Just wanted to
let you know. I also believe changing the patch status to "Waiting on
Author" would be appropriate.

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
wip.patch application/octet-stream 51.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2021-06-01 12:41:13 Re: security_definer_search_path GUC
Previous Message Robert Haas 2021-06-01 12:15:08 Re: storing an explicit nonce