| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: Add common function ReplicationOriginName. |
| Date: | 2022-09-20 08:35:58 |
| Message-ID: | CAJ7c6TPA=nczG2=oFckm7cTJKDFsYo-2X4cPirohj6J5sFmd-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Amit,
> I think it is better to use Size. Even though, it may not fail now as
> the size of names for origin will always be much lesser but it is
> better if we are consistent. If we agree with this, then as a first
> patch, we can make it to use Size in existing places and then
> introduce this new function.
OK, here is the updated patchset.
* 0001 replaces int's with Size's in the existing code
* 0002 applies Peter's patch on top of 0001
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Pass-Size-as-a-2nd-argument-for-snprintf-in-table.patch | application/octet-stream | 3.2 KB |
| v2-0002-Add-common-function-ReplicationOriginName.patch | application/octet-stream | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melih Mutlu | 2022-09-20 08:47:40 | Re: Summary function for pg_buffercache |
| Previous Message | Peter Smith | 2022-09-20 08:25:33 | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |