| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: Unit tests for SLRU |
| Date: | 2022-11-10 15:40:44 |
| Message-ID: | CAJ7c6TOzQ8F3Bhe8fSZjYWbjHCP+p7OVwSxVcUR8Q-WZPNqRvg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Michael,
Thanks for the review and also for committing 5ca3645.
> This patch redesigns SimpleLruInit() [...]
> I am not really convinced that this is something that a
> patch aimed at extending testing coverage should redesign, especially
> with a routine as old as that.
> [...] you'd better put this facility in src/test/modules/
Fair enough. PFA the corrected patch v5.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Add-unit-tests-for-SLRU.patch | application/octet-stream | 15.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2022-11-10 16:22:28 | Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL |
| Previous Message | Tom Lane | 2022-11-10 15:28:24 | Re: Database "contrib_regression" does not exist during testing |