| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | Jan Nidzwetzki <jan(at)planetscale(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add tests for src/backend/nodes/extensible.c |
| Date: | 2026-08-26 15:27:10 |
| Message-ID: | CAJ7c6TOxnQT730RoE_X86RFCRWGL1G_vhQrdfx10p75PH=V3_g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Jan,
> Apart from this, the patch looks good to me.
Thanks for the fast and detailed feedback. I will submit an updated
patch shortly.
> The assert fires because parseRelOptions() counts every option
> registered for the kind, while heap_reloptions() still passes a fixed
> parse table, so numoptions exceeds num_relopt_elems, and I did not find
> an easy way to fix that.
I came to the same conclusion. The idea of supporting extendable
per-table options independent of TAM sounds nice though. I will
investigate this and propose a separate path, unless anyone believes
there is no way Postgres should provide such a possibility.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2026-08-26 15:39:48 | Re: pg_upgrade --copy-file-range fails with EINVAL on Linux 4.19 |
| Previous Message | Andres Freund | 2026-08-26 15:17:55 | Re: Internal error codes triggered by regression tests and user queries, take 2 |