Re: GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere.

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Amul Sul <sulamul(at)gmail(dot)com>
Subject: Re: GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere.
Date: 2022-07-20 11:35:24
Message-ID: CAJ7c6TOe2MprcGv0OYDvm7QjontgfxkhsigWcm=1eC3+kTSCMQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Amul,

> - *tli = replayTLI;
> + if (tli)
> + *tli = replayTLI;

I would guess the difference here is that GetStandbyFlushRecPtr is
static. It is used 3 times in walsender.c and in all cases the
argument can't be NULL.

So I'm not certain what we will gain from the proposed check.

--
Best regards,
Aleksander Alekseev

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2022-07-20 11:39:09 Is it correct to say, "invalid data in file \"%s\"", BACKUP_LABEL_FILE in do_pg_backup_stop?
Previous Message Dilip Kumar 2022-07-20 11:26:47 Re: making relfilenodes 56 bits