Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Arseniy Mukhin <arseniy(dot)mukhin(dot)dev(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>
Subject: Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments
Date: 2025-06-20 14:01:41
Message-ID: CAJ7c6TOCJG2p0Ob9Z7mXQRhkmRX_mxBay198Z173t4=PZr=yEQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

> Given the quality of BSD indent code, I have _always_ found it easier to
> modify pgindent. ;-

:D Initially I thought that the problem was simple enough to solve it
in C, but this turned out not to be true.

> It's going to be simpler to modify pgindent then. PFA the updated patch.

I noticed a mistake in v2. Here is the corrected patch. Changes
comparing to the previous version:

```
- $lines[-1] =~ s!/(.+)\*/!/$1\n \*/!;
+ $lines[-1] =~ s!(.+) \*/!$1\n \*/!;
```

--
Best regards,
Aleksander Alekseev

Attachment Content-Type Size
v3-0001-pgindent-improve-formatting-of-multiline-comments.patch application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shihao zhong 2025-06-20 14:13:38 Re: Fixes inconsistent behavior in vacuum when it processes multiple relations
Previous Message Bruce Momjian 2025-06-20 13:56:41 Re: [PATCH] pg_bsd_indent: improve formatting of multiline comments