| From: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Evgeniy Gorbanev <gorbanyoves(at)basealt(dot)ru> |
| Subject: | Re: Missing NULL check after calling ecpg_strdup |
| Date: | 2025-07-11 16:22:36 |
| Message-ID: | CAJ7c6TNvFTPUTZQuNAoqgzaSGz-iM4XR61D7vEj5PsQXwg2RyA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Evgeniy,
> In case of out_of_memory, the ecpg_strdup function may return NULL.
> Checks should be added in src/interfaces/ecpg/ecpglib/execute.c.
> Patch attached.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
The patch looks correct, but I believe it's incomplete. It misses
several other places where ecpg_strdup() is called without proper
checks. A correct patch would look like the one attached.
While working on it I noticed a potentially problematic strcmp call,
marked with XXX in the patch. I didn't address this issue in v2.
Thoughts?
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-proper-checks-for-ecpg_strdup-return-value.patch | text/x-patch | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-07-11 16:54:01 | Re: CHECKPOINT unlogged data |
| Previous Message | Andres Freund | 2025-07-11 16:14:06 | Re: Adding basic NUMA awareness |