| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, wenjing zeng <wjzeng2012(at)gmail(dot)com> |
| Subject: | Re: CREATE TABLE ( .. STORAGE ..) |
| Date: | 2022-06-16 13:40:55 |
| Message-ID: | CAJ7c6TNntQrB2NsD7zWeFosNeJkqMtjX1th6peKGP0A+YR2bsQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Matthias,
> Apart from this comment on the format of the patch, the result seems solid.
Many thanks.
> When updating a patchset generally we try to keep the patches
> self-contained, and update patches as opposed to adding incremental
> patches to the set.
My reasoning was to separate my changes from the ones originally
proposed by Teodor. After doing `git am` locally a reviewer can see
them separately, or together with `git diff origin/master`, whatever
he or she prefers. The committer can choose between committing two
patches ony by one, or rebasing them to a single commit.
I will avoid the "patch for the patch" practice from now on. Sorry for
the inconvenience.
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sajti Zsolt Zoltán | 2022-06-16 15:00:10 | Global variable/memory context for PostgreSQL functions |
| Previous Message | Justin Pryzby | 2022-06-16 13:23:07 | Re: fix stats_fetch_consistency value in postgresql.conf.sample |