Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests
Date: 2023-04-11 19:10:06
Message-ID: CAJ7c6TNcuo8jF+uFv5nWx8XTumg0Dqzyz7ynpFoK_s0DsW63jA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Andrew,

> I don't think we can protect against all possible user names. Wouldn't it be better to run the tests under an OS user with a different name, like "marmaduke"? ("user" is a truly terrible default user name).

100% agree. The point is not to protect against all possible user
names but merely to reduce the likelihood of the problem. For this
particular test there is no difference which keyword to use for the
test. I realize this is a minor problem, however the fix is trivial
too.

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2023-04-11 19:22:12 Re: Show various offset arrays for heap WAL records
Previous Message Andrew Dunstan 2023-04-11 19:03:47 Re: [PATCH] Use role name "system_user" instead of "user" for unsafe_tests