Re: [PATCH] ALTER TABLE ... SET STORAGE default

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: Nikita Malakhov <hukutoc(at)gmail(dot)com>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] ALTER TABLE ... SET STORAGE default
Date: 2022-08-22 13:28:15
Message-ID: CAJ7c6TNZrdDckBw7i0fEt8DdU=svYVFLZDQRMVrVMkrQaiksMg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Nikita,

> This seems a little bit confusing and thus very unfriendly for the user, because the actual meaning
> of the same 'DEFAULT' option will be different for each data type, and to check storage mode user
> has to query full table (or column) description.
> I'd rather add a paragraph in documentation describing each data type default storage mode.

I agree that "SET STORAGE default" syntax leaves much to be desired.

Personally I would prefer "RESET STORAGE" and "RESET COMPRESSION". But
since we already have "SET COMPRESSION default" this going to be
either two commands that do the same thing, or a broken backward
compatibility. Simply removing "SET COMPRESSION default" will make the
syntax consistent too, but again, this would be a broken backward
compatibility. I would argue that a sub-optimal but consistent syntax
that does the job is better than inconsistent syntax and figuring out
the default storage strategy manually.

But let's see what is others people opinion.

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2022-08-22 13:44:42 Re: Supporting TAP tests with MSVC and Windows
Previous Message Nikita Malakhov 2022-08-22 13:15:39 Re: [PATCH] ALTER TABLE ... SET STORAGE default