| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Convert *GetDatum() and DatumGet*() macros to inline functions |
| Date: | 2022-09-08 09:26:06 |
| Message-ID: | CAJ7c6TNYVEvvRVS9OwZEPEQBDRaFUG+1yr4Sx3Jb_rbAMfohyQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Peter,
> > 3. Go with your patch and just fix up the warnings about uninitialized
> > variables. But that seems the least principled to me.
>
> IMO the 3rd option is the lesser evil. Initializing four bools/ints in
> order to make Clang 11 happy doesn't strike me as such a big deal. At
> least until somebody reports a bottleneck for this particular reason.
> We can optimize the code when and if this will happen.
Since the first patch was applied, cfbot now complains that it can't
apply the patchset. Here is the rebased version.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Convert-GetDatum-and-DatumGet-macros-to-inline-fu.patch | application/octet-stream | 41.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2022-09-08 09:29:38 | Re: more descriptive message for process termination due to max_slot_wal_keep_size |
| Previous Message | Alvaro Herrera | 2022-09-08 09:23:09 | pgsql: Fix perltidy breaking perlcritic |