Re: Convert *GetDatum() and DatumGet*() macros to inline functions

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Convert *GetDatum() and DatumGet*() macros to inline functions
Date: 2022-09-12 15:59:09
Message-ID: 61c44649-2a70-1a83-48d3-aa79203686f8@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 08.09.22 11:26, Aleksander Alekseev wrote:
>>> 3. Go with your patch and just fix up the warnings about uninitialized
>>> variables. But that seems the least principled to me.
>>
>> IMO the 3rd option is the lesser evil. Initializing four bools/ints in
>> order to make Clang 11 happy doesn't strike me as such a big deal. At
>> least until somebody reports a bottleneck for this particular reason.
>> We can optimize the code when and if this will happen.
>
> Since the first patch was applied, cfbot now complains that it can't
> apply the patchset. Here is the rebased version.

committed, thanks

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2022-09-12 16:01:22 Re: Support for Rust
Previous Message Peter Eisentraut 2022-09-12 15:49:36 Re: preserve timestamps when installing headers