| From: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
|---|---|
| To: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Mats Kindahl <mats(at)timescale(dot)com> |
| Subject: | Re: Table AM and DROP TABLE [ Was: Table AM and DDLs] |
| Date: | 2021-09-27 11:59:22 |
| Message-ID: | CAJ7c6TNWBVy1RHV-m-Ugg8+8PRY2NvOGm-RBwNYP7Kn5Tkq9bA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
> As a matter of fact, I think the patch I suggested is the right approach:
> let me elaborate on why.
> [...]
> It is straightforward to replace it by implementing the Table AM methods
> above, but we are missing a callback on dropping the table. If we have that,
> we can record the table-to-be-dropped in a similar manner to how the heap AM
> does it and register a transaction callback using RegisterXactCallback.
Since no one objected in 5 months, I assume Mats made a good point. At least,
personally, I can't argue.
The patch looks good to me except for the fact that comments seem to be
inaccurate in light of the discussion. The corrected patch is attached.
I'm going to mark it as "Ready for Committer" unless anyone objects.
--
Best regards,
Aleksander Alekseev
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-callback-to-reset-filenode-to-table-access-metho.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-09-27 12:21:39 | Re: [PATCH] Cross-reference comments on signal handling logic |
| Previous Message | Daniel Gustafsson | 2021-09-27 11:50:39 | Re: can we add some file(msvc) to gitignore |